-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixUnstable: add util-linuxMinimal to nativeBuildInputs; skip flakey test #117295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, builds for me locally.
Result of 5 packages built successfully:
2 suggestions:
Result of 5 packages built successfully:
2 suggestions:
|
This comment has been minimized.
This comment has been minimized.
Waiting on the outcome of NixOS/nix#4659. |
Fixes an issue in tests where they can fail with `../common.sh: line 92: unshare: command not found`.
429948b
to
1143d07
Compare
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 5 packages built:
|
We want to unblock channels, so I'm going to merge as soon as this is green. If this is actually blocking, then we want this in ASAP to prepare for upcoming security bumps. If it isn't, we'll need to disable the flakey test until upstream can figure out why this is happening. EDIT: Since we want to unblock, I'm also adding a commit that will skip the flakey test until we know how to fix it (especially since ofborg has now failed with the same issue). |
Fixes an issue in tests where they can fail with
../common.sh: line 92: unshare: command not found
.Motivation for this change
Similar to #114602, but is more in-line with what happens upstream: uses
util-linuxMinimal
rather thanutil-linux
, and places it inbuildInputs
rather thannativeBuildInputs
.EDIT: Upstream is trending towards moving it into nativeBuildInputs, and we want to see if this unblocks channels, so I moved it to nativeBuildInputs.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)