nixos/gitea: set umask for secret creation #121299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg test gitea |
github-actions
bot
added
6.topic: nixos
42 tasks
dotlambda
reviewed
Apr 30, 2021
| @@ -477,6 +477,7 @@ in | |||
| in '' | |||
| # copy custom configuration and generate a random secret key if needed | |||
| ${optionalString (cfg.useWizard == false) '' | |||
| umask 027 | |||
There was a problem hiding this comment.
You don't want to run this in a sub-shell?
There was a problem hiding this comment.
AFAIU the only file creation operations only happen within this block, so unless I'm missing something right now, this shouldn't be needed.
There was a problem hiding this comment.
That will cause problems though if another file creation has to be added at a later point.
ofborg
bot
added
10.rebuild-darwin: 0
This ensures that newly created secrets will have the permissions `0640`. With this change it's ensured that no sensitive information will be word-readable at any time. Related to NixOS#121293. Strictly speaking this is a breaking change since each new directory (including data-files) aren't world-readable anymore, but actually these shouldn't be, unless there's a good reason for it.
dotlambda
reviewed
Apr 30, 2021
|
|
||
| # Migrate LFS_JWT_SECRET filename | ||
| if [[ -e ${oldLfsJwtSecret} && ! -e ${lfsJwtSecret} ]]; then | ||
| mv ${oldLfsJwtSecret} ${lfsJwtSecret} |
There was a problem hiding this comment.
This will preserve permissions but I guess that's fine.
dotlambda
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This ensures that newly created secrets will have the permissions
0640. With this change it's ensured that no sensitive information willbe word-readable at any time.
Related to #121293.
Strictly speaking this is a breaking change since each new directory
(including data-files) aren't world-readable anymore, but actually these
shouldn't be, unless there's a good reason for it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)