Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode extension updates #122913

Merged
merged 2 commits into from
May 14, 2021
Merged

Vscode extension updates #122913

merged 2 commits into from
May 14, 2021

Conversation

kinnison
Copy link
Contributor

Motivation for this change

As we approach the final release of 21.05 it would be good to keep vscode extensions as up-to-date as we can. Especially the live-share extension whose compatibility might depend on being up-to-date between systems. This change updates the live-share extension and further updates the python extension relative to the last PR I submitted.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • ms-python.python: 692M -> 681M
    • ms-vsliveshare-vsliveshare: 752M -> 752M
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @lukegb

@kinnison kinnison requested a review from jonringer as a code owner May 13, 2021 22:39
@ofborg ofborg bot requested a review from jraygauthier May 13, 2021 23:19
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 13, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122913 at d91ae6a run on x86_64-linux 1

2 packages built successfully:
  • vscode-extensions.ms-python.python
  • vscode-extensions.ms-vsliveshare.vsliveshare

@kinnison kinnison mentioned this pull request May 14, 2021
@Mic92 Mic92 merged commit a5269ff into NixOS:master May 14, 2021
@kinnison kinnison deleted the vscode-extension-updates branch May 14, 2021 10:54
@deviant
Copy link
Member

deviant commented May 15, 2021

I think you missed #122731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants