Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme-sh: 2.8.9 -> 2.9.0 #125568

Merged
merged 1 commit into from
Jun 6, 2021
Merged

acme-sh: 2.8.9 -> 2.9.0 #125568

merged 1 commit into from
Jun 6, 2021

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jun 3, 2021

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/acme.sh/versions.

meta.description for acme-sh is: "A pure Unix shell script implementing ACME client protocol"

meta.homepage for acme-sh is: "https://acme.sh/"

meta.changelog for acme-sh is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/x44p8k5nqcmg3xrp2pb2sq701l38l4qw-acme.sh-2.9.0/bin/acme.sh passed the binary check.

  • 1 of 1 passed binary check by having a zero exit code.

  • 1 of 1 passed binary check by having the new version present in output.

  • found 2.9.0 with grep in /nix/store/x44p8k5nqcmg3xrp2pb2sq701l38l4qw-acme.sh-2.9.0

  • found 2.9.0 in filename of file in /nix/store/x44p8k5nqcmg3xrp2pb2sq701l38l4qw-acme.sh-2.9.0

  • directory tree listing: https://gist.github.com/69cae13333aeb871ac5e71a54a4722a6

  • du listing: https://gist.github.com/3ce76be5aed005dae3009d3628940e54


Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
acme-sh
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/x44p8k5nqcmg3xrp2pb2sq701l38l4qw-acme.sh-2.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A acme-sh https://github.com/r-ryantm/nixpkgs/archive/804dc91a4e9b9222db7473b76638139e3babf145.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/x44p8k5nqcmg3xrp2pb2sq701l38l4qw-acme.sh-2.9.0
ls -la /nix/store/x44p8k5nqcmg3xrp2pb2sq701l38l4qw-acme.sh-2.9.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • acme-sh

Maintainer pings

cc @balsoft @mkaito for testing.

@ofborg ofborg bot requested review from mkaito and balsoft June 3, 2021 21:35
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 3, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 125568 at 804dc91 run on x86_64-linux 1

1 package built successfully:
  • acme-sh
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/admin/acme.sh/default.nix:15:3:

       |
    15 |   installPhase = ''
       |   ^
    
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/admin/acme.sh/default.nix:33:5:

       |
    33 |     license = licenses.gpl3;
       |     ^
    

@lukegb
Copy link
Contributor

lukegb commented Jun 6, 2021

Changelog:

ACME v1 is removed.
Bug fixes.

@lukegb lukegb merged commit aa24e64 into NixOS:master Jun 6, 2021
@r-ryantm r-ryantm deleted the auto-update/acme.sh branch June 6, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants