Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: make GIO_EXTRA_MODULES a session variable #126832

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

ncfavier
Copy link
Member

At the moment, Thunar doesn't render thumbnails for files in the trash, because the tumbler instance started by dbus can't find the gvfs GIO extra modules (tumbler doesn't depend on gvfs so they're not added to GIO_EXTRA_MODULES in the wrapGAppsHook wrapper, if I understand things correctly).

This PR makes GIO_EXTRA_MODULES a sessionVariable instead of a variable in the three modules that define it, including the gvfs module. This shouldn't break anything, and I have confirmed that it fixes my issue.

cc @worldofpeace @jtojnar

Allow applications started by the systemd user session manager to find
their GIO_EXTRA_MODULES.
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) labels Jun 14, 2021
@jtojnar
Copy link
Member

jtojnar commented Jun 14, 2021

It might potentially cause conflicts if someone sets environment.variables.GIO_EXTRA_MODULES manually, see #122244. But not much we can do about that.

@ncfavier
Copy link
Member Author

ncfavier commented Jun 14, 2021

Ah yeah I just noticed that. But that's a separate issue that should be resolved eventually.

@jtojnar
Copy link
Member

jtojnar commented Dec 6, 2021

Thanks, let’s give it a spin.

@jtojnar jtojnar merged commit 75eaab3 into NixOS:master Dec 6, 2021
@ncfavier ncfavier deleted the gio-extra-modules branch December 6, 2021 15:25
@ncfavier ncfavier restored the gio-extra-modules branch December 16, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants