Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antlr: make 4.8 default #127545

Merged
merged 1 commit into from
Jun 20, 2021
Merged

antlr: make 4.8 default #127545

merged 1 commit into from
Jun 20, 2021

Conversation

liff
Copy link
Contributor

@liff liff commented Jun 20, 2021

Motivation for this change

Addressing #40015. Added a new antlr2 attribute for the old version and updated the derivations that used plain antlr to use that instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation labels Jun 20, 2021
@liff
Copy link
Contributor Author

liff commented Jun 20, 2021

sqlitebrowser doesn’t actually use ANTLR anymore it looks like so I removed it.

cc @peterhoeg

@ofborg ofborg bot requested a review from peterhoeg June 20, 2021 11:17
@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 20, 2021 •
edited
Loading

Result of nixpkgs-review pr 127545 at b2bf2c6 run on aarch64-linux 1

4 packages built successfully:
  • antlr
  • antlr2
  • nixos-install-tools
  • sqlitebrowser

Result of nixpkgs-review pr 127545 at b2bf2c6 run on x86_64-linux 1

4 packages built successfully:
  • antlr
  • antlr2
  • nixos-install-tools
  • sqlitebrowser

@SuperSandro2000 SuperSandro2000 merged commit 0c72a4f into NixOS:master Jun 20, 2021
@liff liff deleted the antlr/v4-is-default branch November 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ryantm ryantm Awaiting requested review from ryantm

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liff @r-rmcgibbo @SuperSandro2000