Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-generic-build: allow mainProgram to be set #129093

Merged
merged 1 commit into from
Jul 3, 2021
Merged

haskell-generic-build: allow mainProgram to be set #129093

merged 1 commit into from
Jul 3, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jul 3, 2021 •
edited
Loading

Motivation for this change

So that nix run works when the package name mismatches the binary. See #120692.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member

maralorn commented Jul 3, 2021

Seems like an easy win. Thank you!

@maralorn maralorn merged commit 1e61298 into NixOS:master Jul 3, 2021
@siraben siraben deleted the haskell-mainProgram branch July 3, 2021 12:00
sternenseemann added a commit to NixOS/distribution-nixpkgs that referenced this pull request May 19, 2022
@sternenseemann
feat(Meta): add support for setting meta.mainProgram
f3915c4 
Upstream haskellPackages.mkDerivation supports this since
NixOS/nixpkgs#129093 / 06fb9a9.

Reference: NixOS/cabal2nix#541
@sternenseemann sternenseemann mentioned this pull request May 19, 2022
Merged
sternenseemann added a commit to NixOS/distribution-nixpkgs that referenced this pull request May 22, 2022
@sternenseemann
feat(Meta): add support for setting meta.mainProgram
bf0d5f1 
Upstream haskellPackages.mkDerivation supports this since
NixOS/nixpkgs#129093 / 06fb9a9.

Reference: NixOS/cabal2nix#541
sternenseemann added a commit to NixOS/cabal2nix that referenced this pull request Jul 21, 2022
@sternenseemann
feat(Meta): add support for setting meta.mainProgram
36f9ccb 
Upstream haskellPackages.mkDerivation supports this since
NixOS/nixpkgs#129093 / 06fb9a9.

Reference: #541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann is a code owner

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siraben @maralorn