git-annex: 8.20210630 -> 8.20210714

[Atemu]

Motivation for this change

https://git-annex.branchable.com/news/version_8.20210714/ fixes a few critical issues.

It will be a while until the update would make it through the usual haskellPackages set update cycle and this is a purely user-facing leaf package.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Relase notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 130403 at 803ce47 run on x86_64-linux 1

4 packages built successfully:

• git-annex (haskellPackages.git-annex)
• git-annex-metadata-gui
• python38Packages.git-annex-adapter
• python39Packages.git-annex-adapter

5 suggestions:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/development/haskell-modules/generic-builder.nix:691:59:

      |
  691 | // optionalAttrs (args ? installPhase)           { inherit installPhase; }
      |                                                           ^
  

• warning: build-tools-in-build-inputs

  git is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/development/haskell-modules/generic-builder.nix:311:3:

      |
  311 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs;
      |   ^
  

• warning: build-tools-in-build-inputs

  rsync is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/development/haskell-modules/generic-builder.nix:311:3:

      |
  311 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs;
      |   ^
  

• warning: missing-phase-hooks

  checkPhase should probably contain runHook preCheck and runHook postCheck.

  Near pkgs/development/haskell-modules/generic-builder.nix:685:59:

      |
  685 | // optionalAttrs (args ? checkPhase)             { inherit checkPhase; }
      |                                                           ^
  

• warning: build-tools-in-build-inputs

  which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/development/haskell-modules/generic-builder.nix:311:3:

      |
  311 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs;
      |   ^
  

[cdepillabout]

@Atemu it is generally easier for us if haskell-related fixes go to the haskell-updates branch. Although you're right that it sometimes take a few days for those fixes to reach master.

How critical of an update is this? Is git-annex completely unusable right now? Or is this a critical security update?

(edit: I just fixed this on haskell-updates in cd1fedf on #130424.)

[Atemu]

Got it, will do that next time.

Not that critical but still something you'd want: It's a few bugs that can cause the git repo to corrupt that got fixed.

Thanks, will close in favour of that one!