Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdevil: add missing dependency libdeflate #132220

Closed
wants to merge 1 commit into from
Closed

libdevil: add missing dependency libdeflate #132220

wants to merge 1 commit into from

Conversation

int-index
Copy link
Contributor

Motivation for this change

Fix #132218

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@int-index int-index mentioned this pull request Jul 31, 2021
Closed
@ofborg ofborg bot requested a review from Phreedom July 31, 2021 14:14
@risicle
Copy link
Contributor

risicle commented Jul 31, 2021

This will need to be rebased to staging.

@risicle
Copy link
Contributor

risicle commented Jul 31, 2021 •
edited
Loading

Hmm, I can't test pkgsMusl.libdevil, as python appears to be broken there. Just spotted step 2 of the issue.

@int-index
libdevil: add missing dependency libdeflate
c5f3dce 
fixes a build error with pkgsMusl:
	/nix/store/vf20zcyqr3qzcjhdidzk377qankcqsqa-binutils-2.35.1/bin/ld: cannot find -ldeflate
@int-index int-index changed the base branch from master to staging July 31, 2021 16:39
@int-index int-index closed this Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phreedom Phreedom Awaiting requested review from Phreedom

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@ttuegel ttuegel Awaiting requested review from ttuegel

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libdevil+pkgsMusl: cannot find -ldeflate
2 participants
@int-index @risicle