Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: update stackage and hackage #135453

Merged
merged 48 commits into from
Sep 3, 2021
Merged

Conversation

expipiplus1
Copy link
Contributor

This Merge

This PR is the regular merge of the haskell-updates branch into master.

This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates.

I will aim to merge this PR by 2021-09-06. If I can merge it earlier, there might be successor PRs in that time window. As part of our rotation @cdepillabout will continue these merges from 2021-09-06 to 2021-09-20.

haskellPackages Workflow Summary

Our workflow is currently described in
pkgs/development/haskell-modules/HACKING.md.

The short version is this:

  • We regularly update the Stackage and Hackage pins on haskell-updates (normally at the beginning of a merge window).
  • The community fixes builds of Haskell packages on that branch.
  • We aim at at least one merge of haskell-updates into master every two weeks.
  • We only do the merge if the mergeable job is succeeding on hydra.
  • If a maintained package is still broken at the time of merge, we will only merge if the maintainer has been pinged 7 days in advance. (If you care about a Haskell package, become a maintainer!)

This is the follow-up to #133422.

maralorn and others added 9 commits August 22, 2021 19:58
This commit has been generated by maintainers/scripts/haskell/update-stackage.sh
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
@sternenseemann
Copy link
Member

sternenseemann commented Aug 23, 2021

@expipiplus1 I'll look at fixing ghc921 for aarch64-linux later if you don't feel like doing it! (Edit: linux ofc)

@expipiplus1
Copy link
Contributor Author

@expipiplus1 I'll look at fixing ghc921 for aarch64-linux later if you don't feel like doing it! (Edit: linux ofc)

Sure, if you have enough energy. Otherwise I'll see about taking a look before my period ends!

sternenseemann and others added 4 commits August 23, 2021 19:12
Compiling GHC on Hydra takes 3h or more (with -j2) whereas even on an
outdated CPU GHC can be compiled in under an hour with -j4. To get a
higher NIX_BUILD_CORES value at build time, we'll have to mark GHC
big-parallel.
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Aug 24, 2021

haskell-updates build report from hydra

evaluation 1701009 of nixpkgs commit 5f6b37f as of 2021-09-01 06:15 UTC

Build summary

Platform Failed ❌ DependencyFailed ❗ TimedOut ⌛🚫 Unfinished ⏳ Success ✔️
aarch64-linux 📱 24 10 3 6671
x86_64-darwin 🍎 53 29 1 1 6577
x86_64-linux 🐧 5 1 6745

Maintained packages with build failure

Unmaintained packages with build failure

70 job(s)

Unmaintained packages with failed dependency

40 job(s)

Report generated with maintainers/scripts/haskell/hydra-report.hs

sternenseemann and others added 2 commits August 28, 2021 16:17
GHC 9.2.1-rc1 needs to run xattr in ghc.mk unconditionally. The fix for
this and support for the XATTR environment variable have only been added
to the GHC 8.10 series so far.
@sternenseemann
Copy link
Member

sternenseemann commented Aug 29, 2021

We'll need to replace ghc8105Binary by ghc8107Binary most likely to solve the issues on x86_64-darwin. That's not super urgent however as it's used on aarch64-darwin exclusively atm.

Will need some investigation if GHC 9.2.1 just suffers from the same bug or we'll need to change something in its build.

@domenkozar
Copy link
Member

I'm on it.

@ofborg ofborg bot requested a review from lostnet August 29, 2021 13:42
github-actions bot and others added 2 commits August 30, 2021 00:06
GHC 8.8.4 seems to be quite susceptible to flaky build failures when
using more cores. Since we don't care about speed too much with this
one, let's disable big-parallel again.
@domenkozar
Copy link
Member

Given that all packages build, is there any reason to hold this longer?

@sternenseemann
Copy link
Member

The OpenSSL bump (?) on master caused some regressions which need fixing (namely haskell-language-server has started failing).

@domenkozar
Copy link
Member

That seems transient: https://hydra.nixos.org/build/151735600

@sternenseemann
Copy link
Member

Interesting, I had already restarted it once…

github-actions bot and others added 7 commits August 31, 2021 00:09
This also adds a top-level `termonad` alias for
`termonad-with-packages`.
termonad: add meta.mainProgram to easily run with flakes
Seems like there is either a fundamental issue with how our derivation
works or an upstream bug prevent GHC 9.2.1 from compiling on macOS using
nixpkgs. Until someone fixes that or rc2 comes around, we can save the
build time.
@domenkozar
Copy link
Member

@expipiplus1 What do you think about merging the branch as-is?

This commit has been generated by maintainers/scripts/haskell/mark-broken.sh
@expipiplus1 expipiplus1 merged commit 5942b67 into master Sep 3, 2021
@expipiplus1
Copy link
Contributor Author

Thanks everyone!

nh2 added a commit to nh2/nixpkgs that referenced this pull request Sep 20, 2021
…endency.

GHC HQ switched the musl bindists from gmp to `integer-simple`
with GHC >= 8.10.6, but this was not reflected in the nixpkgs update:

* commit 6f12424: ghc: 8.10.5-binary -> 8.10.7-binary
  From PR NixOS#135453

See also NixOS#130441.
sternenseemann pushed a commit that referenced this pull request Sep 23, 2021
…endency.

GHC HQ switched the musl bindists from gmp to `integer-simple`
with GHC >= 8.10.6, but this was not reflected in the nixpkgs update:

* commit 6f12424: ghc: 8.10.5-binary -> 8.10.7-binary
  From PR #135453

See also #130441.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants