Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.carbon-now-cli: init at 1.4.0 #139151

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

Adds the cli client for https://carbon.now.sh/.

This is my first time adding a package to nodePackages, so I'm not sure I did it 100% correctly.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 23, 2021

Result of nixpkgs-review pr 139151 at e0609ea run on x86_64-linux 1

1 package failed to build:
1 package skipped due to time constraints:
  • lumo
8 packages built successfully:
  • deltachat-desktop
  • fast-cli
  • joplin
  • postcss-cli
  • shepherd
  • vimPlugins.coc-prettier
  • vimPlugins.coc-stylelint
  • vscode-extensions.vadimcn.vscode-lldb
5 suggestions:
  • warning: unused-argument

    Unused argument: lib.
    Near pkgs/development/node-packages/node-packages.nix:3:54:

      |
    3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
      |                                                      ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:34:14:

       |
    34 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/development/node-packages/node-packages.nix:3:46:

      |
    3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
      |                                              ^
    
  • warning: unused-argument

    Unused argument: nix-gitignore.
    Near pkgs/development/node-packages/node-packages.nix:3:31:

      |
    3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
      |                               ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:34:14:

       |
    34 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 139151 at e0609ea run on aarch64-linux 1

3 packages failed to build:
1 package skipped due to time constraints:
  • lumo
6 packages built successfully:
  • deltachat-desktop
  • postcss-cli
  • shepherd
  • vimPlugins.coc-prettier
  • vimPlugins.coc-stylelint
  • vscode-extensions.vadimcn.vscode-lldb
5 suggestions:
  • warning: unused-argument

    Unused argument: nix-gitignore.
    Near pkgs/development/node-packages/node-packages.nix:3:31:

      |
    3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
      |                               ^
    
  • warning: unused-argument

    Unused argument: lib.
    Near pkgs/development/node-packages/node-packages.nix:3:54:

      |
    3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
      |                                                      ^
    
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/development/node-packages/node-packages.nix:3:46:

      |
    3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
      |                                              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:34:14:

       |
    34 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:34:14:

       |
    34 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@SuperSandro2000 SuperSandro2000 merged commit f8cbea1 into NixOS:master Sep 23, 2021
@rmcgibbo rmcgibbo deleted the carbon-now-cli branch September 23, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants