lilypond-with-fonts: fix lilypond not finding its libraries

[omidmnz]

Fixes #140152. The fix is inspired by how lilypond-with-fonts was
packaged in v18.09.

Motivation for this change

As described in the issue, the lilypond-with-fonts package is broken at the moment.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[yurrriq]

Thanks for calling this out! I've made some inline comments and suggestions. By the way, we should probably migrate from https://github.com/OpenLilyPondFonts/ to https://github.com/openlilylib/notation-fonts at some point.

[omidmnz]

Thanks for calling this out! I've made some inline comments and suggestions. By the way, we should probably migrate from https://github.com/OpenLilyPondFonts/ to https://github.com/openlilylib/notation-fonts at some point.

I fixed the PR with your suggestions, I agree with you that wrapProgram is preferred.

[yurrriq]

Result of nixpkgs-review pr 140490 run on x86_64-linux 1

1 package built:

• lilypond-with-fonts

[yurrriq]

Thanks! Do you have any interest in migrating the fonts? I've created #141162 for tracking.

[omidmnz]

Thanks! Do you have any interest in migrating the fonts? I've created #141162 for tracking.

Of course! But I don't have much experience with OpenLilyLib. But I'll sure dig into it and add my updates to the issue you mentioned.