Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub-batch: 0.4.0 -> 0.4.1 #143843

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

erictapen
Copy link
Member

Motivation for this change

This should fix all bad dependencies listed in #141368, except for image, which I'm pretty sure doesn't have any security implications for sub-batch.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-burns
Copy link
Contributor

r-burns commented Oct 30, 2021

Spurious failure? Not sure what this means:

installer options: --no-channel-add --darwin-use-unencrypted-nix-store-volume --nix-extra-conf-file /tmp/nix.conf --daemon --daemon-user-count 4
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   220  100   220    0     0   1456      0 --:--:-- --:--:-- --:--:--  1456
/dev/fd/63: 2: Syntax error: newline unexpected
child_process.js:642
    throw err;
    ^

@ofborg eval

@SuperSandro2000
Copy link
Member

Spurious failure? Not sure what this means:

yes, but a github action so ofborg eval won't work.

@SuperSandro2000 SuperSandro2000 merged commit a8ea8bb into NixOS:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants