srain: init at 1.3.0 #144992
srain: init at 1.3.0 #144992
Conversation
ofborg
bot
added
8.has: package (new)
|
Known issues：GtkEmojiChooser is only available in GTK4，Srain 2.0 will move to GTK4，SrainApp/srain#279 |
|
Result of 1 package built:
|
|
GUI works. Please follow CONTRIBUTING.md and squash the commits. In your case, the commits are: |
| rewine = { | ||
| email = "[email protected]"; | ||
| github = "wineee"; | ||
| githubId = 22803888; | ||
| name = "Lu Hongxu"; | ||
| }; |
There was a problem hiding this comment.
It will be nice to put this in a separate commit, so exactly 2 commits should be presented in this PR:
maintainers: add rewinefor themaintainers/maintainer-list.nixeditsrain: init at 1.3.0for the package addition
| @@ -0,0 +1,41 @@ | |||
| { lib, stdenv, fetchFromGitHub, pkg-config, gtk3 | |||
There was a problem hiding this comment.
It will be nice to format this file with nixpkgs-fmt.
| { lib, stdenv, fetchFromGitHub, pkg-config, gtk3 | ||
| , libconfig, libsoup, libsecret, openssl, gettext | ||
| , glib, glib-networking, appstream-glib, dbus-glib, gnome | ||
| , python3, python3Packages # sphinx-build |
There was a problem hiding this comment.
Seems that python3 is unused.
| , python3, python3Packages # sphinx-build | |
| , python3Packages # sphinx-build |
| , libconfig, libsoup, libsecret, openssl, gettext | ||
| , glib, glib-networking, appstream-glib, dbus-glib, gnome | ||
| , python3, python3Packages # sphinx-build | ||
| , meson, ninja, makeWrapper, wrapGAppsHook |
There was a problem hiding this comment.
Any reasons to add makeWrapper?
| , meson, ninja, makeWrapper, wrapGAppsHook | |
| , meson, ninja, wrapGAppsHook |
| nativeBuildInputs = [ | ||
| meson ninja pkg-config | ||
| gettext appstream-glib | ||
| makeWrapper wrapGAppsHook |
There was a problem hiding this comment.
Also it will be nice to sort the list elements.
| makeWrapper wrapGAppsHook | |
| wrapGAppsHook |
|
|
||
| mesonBuildType = "release"; |
There was a problem hiding this comment.
The default build type is plain, is it okay to use the default?
Seems that special measures are taken only when this is set to debug.
| mesonBuildType = "release"; |
| meta = with lib; { | ||
| description = "Modern IRC client written in GTK."; | ||
| homepage = "https://srain.im"; | ||
| license = licenses.gpl3; |
There was a problem hiding this comment.
gpl3 is a deprecated license, from this it should be fine to use gpl3Plus.
| license = licenses.gpl3; | |
| license = licenses.gpl3Plus; |
| homepage = "https://srain.im"; | ||
| license = licenses.gpl3; | ||
| platforms = platforms.linux; | ||
| maintainers = with maintainers; [ "rewine" ]; |
There was a problem hiding this comment.
| maintainers = with maintainers; [ "rewine" ]; | |
| maintainers = with maintainers; [ rewine ]; |
| homepage = "https://srain.im"; | ||
| license = licenses.gpl3; | ||
| platforms = platforms.linux; | ||
| maintainers = with maintainers; [ "rewine" ]; |
There was a problem hiding this comment.
| maintainers = with maintainers; [ "rewine" ]; | |
| maintainers = with maintainers; [ rewine ]; |
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)