nodejs-17_x: 17.0.1 -> 17.1.0

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for nodejs-17_x is: "Event-driven I/O framework for the V8 JavaScript engine"

meta.homepage for nodejs-17_x is: "https://nodejs.org"

meta.changelog for nodejs-17_x is: "https://github.com/nodejs/node/releases/tag/v17.1.0"

Updates performed

• Ran passthru.UpdateScript

To inspect upstream changes

Impact

Checks done (click to expand)

---

• built on NixOS
• The tests defined in passthru.tests, if any, passed
• /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0/bin/npx passed the binary check.
• /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0/bin/node passed the binary check.
• /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0/bin/corepack passed the binary check.
• /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0/bin/npm passed the binary check.
• 4 of 4 passed binary check by having a zero exit code.
• 2 of 4 passed binary check by having the new version present in output.
• found 17.1.0 with grep in /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0
• found 17.1.0 in filename of file in /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0

---

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)


First fifty rebuilds by attrpath
nodejs-17_x
nodejs-slim-17_x

Instructions to test this update (click to expand)

---

Either download from Cachix:

nix-store -r /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A nodejs-17_x https://github.com/r-ryantm/nixpkgs/archive/3067b83e14704218f8badd9f437a79aa2455d88c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0
ls -la /nix/store/xbnvjnzb5swzfj4gxld5gnyf7avj5rlm-nodejs-17.1.0/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

• nodejs-17_x
• nodejs-slim-17_x

---

Maintainer pings

cc @cillianderoiste @gilligan @cko @marsam for testing.

[bobrik]

I think this broke on aarch64-darwin (I didn't check anything else).

• https://hydra.nixos.org/build/158127677 broken 17.1.0
• https://hydra.nixos.org/build/157479788 previously working 17.0.1

Seems like there's an upstream issue:

• Node v17.1.0 does not build with --shared-openssl nodejs/node#40783

Note that this was a visible failure in the builds (glad to see those now):

• https://github.com/NixOS/nixpkgs/runs/4202441678

[marsam]

Sorry about that. Unfortunately, I don't have an arch64-darwin to check, but I guess it's something related with gyp.
Would you mind testing this commit https://github.com/marsam/nixpkgs/commit/9af06aeac7645faf91557ac7179bfe29dbbc3c85?

[bobrik]

Same output:

../deps/openssl/openssl/crypto/ct/ct_log.c:173:15: error: use of undeclared identifier 'OPENSSLDIR'; did you mean 'OPENSSL_die'?
      fpath = CTLOG_FILE;
              ^
../deps/openssl/openssl/include/internal/cryptlib.h:71:35: note: expanded from macro 'CTLOG_FILE'
#  define CTLOG_FILE              OPENSSLDIR "/ct_log_list.cnf"
                                  ^
../deps/openssl/config/./archs/darwin64-arm64-cc/asm/include/openssl/crypto.h:413:20: note: 'OPENSSL_die' declared here
ossl_noreturn void OPENSSL_die(const char *assertion, const char *file, int line);
                   ^
../deps/openssl/openssl/crypto/ct/ct_log.c:173:13: warning: incompatible pointer types assigning to 'const char *' from 'void (const char *, const char *, int)' [-Wincompatible-pointer-types]
      fpath = CTLOG_FILE;
            ^ ~~~~~~~~~~
../deps/openssl/openssl/crypto/ct/ct_log.c:173:15: error: expected ';' after expression
      fpath = CTLOG_FILE;
              ^
../deps/openssl/openssl/include/internal/cryptlib.h:71:46: note: expanded from macro 'CTLOG_FILE'
#  define CTLOG_FILE              OPENSSLDIR "/ct_log_list.cnf"
                                             ^
1 warning and 2 errors generated.
make[1]: *** [deps/openssl/openssl.target.mk:1137: /private/tmp/nix-build-nodejs-17.1.0.drv-0/node-v17.1.0/out/Release/obj.target/openssl/deps/openssl/openssl/crypto/ct/ct_log.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm f9008f51be9a617a6690f2c4af33c9c602c4a5da.intermediate
make: *** [Makefile:110: node] Error 2
error: builder for '/nix/store/yv30gnfkjk4zm95bx8zsp07yqbcbc5vk-nodejs-17.1.0.drv' failed with exit code 2

[marsam]

@bobrik would you mind checking whether this commit nodejs/node@65119a8 solves it?

[bobrik]

The build didn't error out quickly, so I assume it works: #149556.