cppe, python3Packages.cppe: fix build with clang #147935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
force-pushed
the
ris-cppe-clang
branch
from
4adb7c5
to
0caec55
Compare
risicle
force-pushed
the
ris-cppe-clang
branch
from
0caec55
to
f2ce374
Compare
sheepforce
approved these changes
Nov 30, 2021
1 task
|
Successfully created backport PR #148018 for |
jonringer
reviewed
Nov 30, 2021
| buildInputs = [ pybind11 ] | ||
| ++ lib.optional stdenv.cc.isClang llvmPackages.openmp; | ||
|
|
||
| NIX_CFLAGS_LINK = lib.optional stdenv.cc.isClang "-lomp"; |
There was a problem hiding this comment.
What's the difference between NIX_CLFAGS_LINK and NIX_LDFLAGS ?
There was a problem hiding this comment.
That is such a good question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #144627 @NixOS/nixos-release-managers
A few tweaks to get this going on clang/darwin, mostly around openmp.
Need to feed
-lompmanually to the python package's link stage as it attempts some compiler flag detection and receives an error when attempting to use-lompbecause it's trying to use it in a build call rather than a linking call.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes