Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: strip binaries in /share #14824

Closed
wants to merge 1 commit into from
Closed

Conversation

layus
Copy link
Member

@layus layus commented Apr 19, 2016

I have only tested this with go 1.5.
Reviews welcome for other versions of go.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @viric, @lethalman and @cstrahan to be potential reviewers

@vcunat
Copy link
Member

vcunat commented Apr 20, 2016

What? Binaries in share/?

[...] that can be shared among different architectures of the same OS.

@dezgeg dezgeg added 0.kind: enhancement Add something new 6.topic: closure size The final size of a derivation, including its dependencies labels Apr 27, 2016
@layus
Copy link
Member Author

layus commented Apr 28, 2016

@viric, @nbp, Do you have any idea why go has executables in share ?

@wkennington
Copy link
Contributor

That's just the way it packages itself. Every distro has it that way and
it's hard to change.

On Thu, Apr 28, 2016, 1:54 PM Guillaume Maudoux [email protected]
wrote:

@viric https://github.com/viric, @nbp https://github.com/nbp, Do you
have any idea why go has executables in share ?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#14824 (comment)

@layus
Copy link
Member Author

layus commented Apr 29, 2016

@wkennington I do not think it has to be that way. For example archlinux has in /usr/lib/go/ the same tree as we have in /nix/store/2zrmd44q1cy7vzbsb2n04lx15kkkld57-go-1.5.3/share/go/.
Their PKGBUILD exports GOROOT_FINAL=/usr/lib/go and GOROOT_BOOTSTRAP=/usr/lib/go[1] and moves some output dirs around after install. Debian also has most go files in /usr/lib/go/[2], but at the cost of an extensive golang-go.install[3].

I would not say that every distro has it that way. But it seems like the fix requires non-trivial modifications.

[1] https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/go#n32
[2] https://packages.debian.org/fr/sid/amd64/golang-go/filelist
[3] http://http.debian.net/debian/pool/main/g/golang/golang_1.6.1-2.debian.tar.xz

@layus
Copy link
Member Author

layus commented Jul 20, 2016

Closing while we are working on #15339

@layus layus closed this Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 6.topic: closure size The final size of a derivation, including its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants