Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.gnome: add autologin delay to catch GDM failures #150980

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

ncfavier
Copy link
Member

Add a 1 second delay to autologin for the gnome test, which would have caught #149539.

We still have a 0-delay autologin test in gnome-xorg, in case there's ever an issue that only arises with AutomaticLoginEnable.

The test times out on failure because it's waiting for a file to appear; is there a way to make it watch for failures while it waits?

@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos labels Dec 16, 2021
@ncfavier
Copy link
Member Author

@ofborg test gnome

@jtojnar
Copy link
Member

jtojnar commented Dec 16, 2021

Could you please include the context in the commit messages so it is available in git blame? A shorter comment in the code would also be helpful.

@ncfavier
Copy link
Member Author

Done.

@ncfavier
Copy link
Member Author

@ofborg test gnome

@ncfavier ncfavier requested a review from jtojnar January 3, 2022 15:49
@jtojnar
Copy link
Member

jtojnar commented Jan 3, 2022

The information in the OP would still be helpful in the commit message.

Catches failures like NixOS#149539
that don't happen with AutomaticLoginEnable.

We still have a 0-delay autologin test in gnome-xorg, in case there's
ever an issue that only arises with AutomaticLoginEnable.
@ncfavier
Copy link
Member Author

Any updates on this?

@jtojnar jtojnar merged commit 5cd5fb7 into NixOS:master Jan 15, 2022
@jtojnar
Copy link
Member

jtojnar commented Jan 15, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants