Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnuradio3_8: Fix build with boost177 #151864

Merged
merged 3 commits into from
Dec 23, 2021
Merged

gnuradio3_8: Fix build with boost177 #151864

merged 3 commits into from
Dec 23, 2021

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Dec 23, 2021 •
edited
Loading

  • gnuradio3_8: Fix build with boost177
  • uhd: 4.0.0.0 -> 4.1.0.5
Motivation for this change

#151469

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar
gnuradio3_8: Fix build with boost177
1b00149 
Fails to compile otherwise, see: NixOS#151469
@doronbehar
uhd: 4.0.0.0 -> 4.1.0.5
03572bd 
Update and remove some input arguments due to changes in cmake variables
upstream.

Add @doronbehar as maintainer.
@doronbehar doronbehar mentioned this pull request Dec 23, 2021
Closed
54 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Dec 23, 2021
@bjornfor
Copy link
Contributor

Nice!

@ofborg ofborg bot requested a review from bjornfor December 23, 2021 09:41
@doronbehar
Copy link
Contributor Author

GNURadio seems to build on Darwin now!

@doronbehar doronbehar merged commit a85892e into NixOS:staging-next Dec 23, 2021
@doronbehar doronbehar deleted the pkg/gnuradio3_8-boost branch December 23, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@tomberek tomberek Awaiting requested review from tomberek

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doronbehar @bjornfor