Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghc c++ exceptions #152037

Closed

Conversation

roberth
Copy link
Member

@roberth roberth commented Dec 24, 2021

Motivation for this change

Fix C++ exception handling in darwin executables linked by GHC.

-fcompact-unwind should probably be applied to all test suites and executables that interface with C++.
Perhaps, after a decade of __compact_unwind existing, it should become the default, but I don't know if the ecosystem is ready for it, so it's opt-in for now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member

I don't think it necessarily makes sense to fix such a GHC deficiency downstream, especially not before upstream has accepted the patch.

@roberth
Copy link
Member Author

roberth commented Mar 31, 2022

not before upstream has accepted the patch.

It has been accepted in 9.4, backported to 9.2.
9.0 has only seen two commits backported since its latest release 3 months ago, so I'm not getting my hopes up for an upstream backport.

Following this up in #166571

@roberth roberth closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants