-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retroarch: 1.10.0 -> 1.10.2; libretro: unstable-2022-01-21 -> unstable-2022-03-30 #163497
Conversation
I didn't test the emulators yet because I have no access to a Linux machine right now (except for a very slow VM) and the macOS derivation, while building, it is not exactly working yet because of the wrapper issue. So I would be grateful if someone can test at least some emulators here. Otherwise I can test it once I get access to a Linux machine. |
Result of 91 packages built:
|
Result of 91 packages built:
|
Tested:
|
CC @aanderse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This still doesn't fix our wrapped retroarch binary, but should be sufficient to build retroarch+cores in Darwin.
Not maintained anymore by upstream.
Result of 90 packages built:
|
Builds fine for me. |
Result of 90 packages built:
|
Description of changes
New release: https://www.libretro.com/index.php/retroarch-1-10-1-release/ and https://www.libretro.com/index.php/retroarch-1-10-2-release/
This PR also partially fix Darwin (macOS) support: you can now successfully open
retroarchBare
by using its bundle:However the wrapped derivation (
retroarch
) still doesn't work, with the sameNo Info.plist file in application bundle or no NSPrincipalClass in the Info.plist file, exiting
error as before. I thought this was because the wrapped binary was a script, but even usingmakeBinaryWrapper
(recently introduced in #124556) would solve this, however it doesn't. I tried some other ideas without success, but I am open for suggestions.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes