go: 1.18rc -> 1.18

[elliot-u410]

Description of changes

Update go_1_18 from 1.18rc1 to 1.18.

Update default version of go from 1.17 -> 1.18.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[elliot-u410]

I may not have named the first commit message correctly.

[elliot-u410]

go_2-dev is likely obsolete now. Removing that is backward breaking and should be a separate PR.

[techknowlogick]

Result of nixpkgs-review pr 164292 run on aarch64-darwin 1

2 packages marked as broken and skipped:

• bazel-watcher
• openscad

2 packages failed to build:

• darktile
• lib3mf

26 packages built:

• automaticcomponenttoolkit
• docker (docker-client)
• docker-gc
• fn-cli
• gamenetworkingsockets
• go
• go_1_17
• kubebuilder
• kubectl
• kubelogin
• nncp
• operator-sdk
• out-of-tree
• prometheus
• prometheus-alertmanager
• prometheus-pushgateway
• prometheus-xmpp-alerts
• python310Packages.dask-gateway-server
• python310Packages.jupyter-repo2docker
• python39Packages.dask-gateway-server
• python39Packages.jupyter-repo2docker
• qbec
• slides
• tarsum
• thefuck
• vgo2nix

[zowoq]

I've dropped the 1.17 -> 1.18 commit, it requires other changes and testing.

[elliot-u410]

Is it just the two failed packages or are there other things needed?

[zowoq]

go_2-dev is likely obsolete now.

No, go_2 is not obsolete.

[zowoq]

Is it just the two failed packages or are there other things needed?

The 1.17 -> 1.18 was incomplete as it was, it didn't change buildGo{Module,Package}. It will cause many rebuilds and likely lots of breakage that needs to be fixed or pinned. See #113230 as an example.

I'll open another PR for 1.17->1.18 bump. #164320

[elliot-u410]

Awesome. Thank you.