Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopls: 0.8.0 -> 0.8.1 #164810

Merged
merged 1 commit into from
Mar 19, 2022
Merged

gopls: 0.8.0 -> 0.8.1 #164810

merged 1 commit into from
Mar 19, 2022

Conversation

euank
Copy link
Member

@euank euank commented Mar 19, 2022

Description of changes

Update gopls.

This also changes the version of go used to build it to go1.18. This is
required for gopls to work with go1.18 code.

It's still backwards compatible with go1.17 code, so building with 1.18
should allow us to support all supported go versions (1.17+1.18)
correctly, while building with 1.17 does not.

Once #164320 merges, this should switch back to buildGoModule.

Upstream release notes may be found here: https://github.com/golang/tools/releases/tag/gopls%2Fv0.8.1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Update gopls.

This also changes the version of go used to build it to go1.18. This is
required for gopls to work with go1.18 code.

It's still backwards compatible with go1.17 code, so building with 1.18
should allow us to support all supported go versions (1.17+1.18)
correctly, while building with 1.17 does not.

Once NixOS#164320 merges, this should switch back to buildGoModule.
@euank
Copy link
Member Author

euank commented Mar 19, 2022

fyi @zowoq, this PR should be updated to buildGoModule once your PR (linked above) merges.

If your PR merges first, I'm happy to do that here.
If this one's first, you can grab it in your PR, or I can do it as a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants