errcheck: 1.6.0 -> unstable-2022-03-26 #167423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
SuperSandro2000
changed the title
SuperSandro2000
requested changes
Apr 8, 2022
SuperSandro2000
changed the title
SuperSandro2000
changed the title
This updates errcheck to a newer version which has go1.18 support. There's no tagged release yet for this, but without this change, this package breaks under go1.18, so it seems worth updating before upstream tags. Related to NixOS#164320 The switch to 'subPackages' was added because 'testdata' contains a 'main_test.go' file which is not meant to be actually tested, and the default checkPhase will try to run 'cd testdata && go test' unless you do _something_ to override it. Since checkPhase doesn't respect 'excludedPackages', but does respect 'subPackages', this seemed like a reasonable way to do that.
SuperSandro2000
force-pushed
the
errcheck-bump
branch
from
658a04d
to
13dedcf
Compare
|
Thanks for cleaning this up and getting it merged, appreciated!
To double check, this was the versioning? I missed the discussion, and looking around I see NixOS/rfcs#107 Is that the best resource for how I should be looking to do this, or is there a better source of info for the correct idioms? |
Yeah, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This updates errcheck to a newer version which has go1.18 support.
There's no tagged release yet for this, but without this change, this
package breaks under go1.18, so it seems worth updating before upstream
tags.
Related to #164320
The switch to 'subPackages' was added because 'testdata' contains a
'main_test.go' file which is not meant to be actually tested, and the
default checkPhase will try to run 'cd testdata && go test' unless you
do something to override it. Since checkPhase doesn't respect
'excludedPackages', but does respect 'subPackages', this seemed like a
reasonable way to do that.
Changelog
There's no actual changelog, but here's the diff:
kisielk/errcheck@v1.6.0...e62617a
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes