[21.11] webkitgtk: disable hardware acceleration #169058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2022
|
Wouldn't a patch like this be much more idiomatic? diff --git a/Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp b/Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp
index 8f10c7e6..9c827a4d 100644
--- a/Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp
+++ b/Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp
@@ -38,7 +38,7 @@ HardwareAccelerationManager& HardwareAccelerationManager::singleton()
}
HardwareAccelerationManager::HardwareAccelerationManager()
- : m_canUseHardwareAcceleration(true)
+ : m_canUseHardwareAcceleration(false)
, m_forceHardwareAcceleration(false)
{
#if !ENABLE(WEBGL) |
Since the update to 2.36, webkitgtk enables hardware acceleration by default. This causes problems in applications like Evolution on specific hardware platforms (Intel Tiger Lake), where HTML views become empty grey panes.
blitz
force-pushed
the
webkitgtk-rendering-issue
branch
from
61e045d
to
6bee055
Compare
True. I've updated the patch. I modified the |
|
Result of 2 packages marked as broken and skipped:
209 packages failed to build:
5 packages built:
|
|
Hm, that's weird. @Mic92 Version: /nix/store/4dm8ra2zipr58x4q8c59pgd6xv6q5bbd-nixpkgs-review-2.6.4 $ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 169058"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs release-21.11:refs/nixpkgs-review/0 pull/169058/head:refs/nixpkgs-review/1
$ git worktree add /home/henri/.cache/nixpkgs-review/pr-169058-1/nixpkgs c093b038d8df8bfcec81d62219b093440adf3e53
Preparing worktree (detached HEAD c093b038d8d)
Updating files: 100% (29052/29052), done.
HEAD is now at c093b038d8d Merge pull request #168903 from NixOS/backport-168855-to-release-21.11
$ git merge --no-commit --no-ff 6bee0550531bf20a7e291393ded04402c3808b30
Automatic merge went well; stopped before committing as requested
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/henri/.cache/nixpkgs-review/pr-169058-1/build.nix
error: attribute 'bijiben' missing
at /home/henri/.cache/nixpkgs-review/pr-169058-1/build.nix:71:9:
70| gnome-recipes
71| gnome."bijiben"
| ^
72| gnome."cheese"
(use '--show-trace' to show detailed location information)Anyway, not related to this PR. |
|
Result of 2 packages marked as broken and skipped:
16 packages failed to build:
198 packages built:
|
|
I am pretty sure hardware acceleration was always on on supported hardware, hence the various bug reports about it. Since disabling it will likely have significant impact on performance e.g. for people using Epiphany web browser, I would rather go with some less invasive method. |
Fair point. What about wrapping evolution with |
|
Closing in favor of #169170. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since the update to webkitgtk 2.36 in #167920, webkitgtk enables hardware acceleration by default. This fully breaks GNOME Evolution for me, because the email compose window becomes unusable.
There is a workaround by setting
WEBKIT_DISABLE_COMPOSITING_MODE=1, but I assume that other apps that use webkit are also affected. So this PR reverts webkit back to its 2.34 behavior of not using hardware acceleration by default.Fixes #168645. Relates to #168532.
Marked as draft until my builds complete.
@NixOS/gnome
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes