Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.36.0 → 2.36.1 #170538

Merged
merged 1 commit into from
Apr 29, 2022
Merged

webkitgtk: 2.36.0 → 2.36.1 #170538

merged 1 commit into from
Apr 29, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Apr 26, 2022 •
edited
Loading

Description of changes

https://webkitgtk.org/2022/04/21/webkitgtk2.36.1-released.html

Possibly fixing #168645, cc @blitz

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Apr 27, 2022
@jtojnar jtojnar merged commit 7487afc into NixOS:master Apr 29, 2022
@jtojnar jtojnar deleted the webkitgtk-2.36.1 branch April 29, 2022 12:36
@jtojnar
Copy link
Member Author

jtojnar commented Apr 29, 2022 •
edited
Loading

Merged and backporting since it is quite likely there are not-yet-announced CVE fixes.

@jtojnar jtojnar added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 29, 2022
@github-actions github-actions bot mentioned this pull request Apr 29, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #170905 for release-21.11.

@github-actions
Copy link
Contributor

The process '/usr/bin/git' failed with exit code 1

@trofi
Copy link
Contributor

trofi commented May 2, 2022

Bisect says 7487afc webkitgtk: 2.36.0 → 2.36.1 broke liferea's test suite on master:

$ nix build -f. liferea
...
liferea> (liferea:5187): GLib-GObject-WARNING **: 08:02:25.054: invalid (NULL) pointer instance
liferea> (liferea:5187): GLib-GObject-CRITICAL **: 08:02:25.054: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
liferea> (liferea:5187): GLib-GObject-WARNING **: 08:02:25.054: invalid (NULL) pointer instance
liferea> (liferea:5187): GLib-GObject-CRITICAL **: 08:02:25.054: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
liferea> Command '['./liferea', '--introspect-dump=/build/tmp-introspecte8qbbari/functions.txt,/build/tmp-introspecte8qbbari/dump.xml']' died with <Signals.SIGSEGV: 11>

@jtojnar jtojnar mentioned this pull request May 2, 2022
Closed
@trofi
Copy link
Contributor

trofi commented May 4, 2022 •
edited
Loading

liferea builds fine from upstream master. There are a few unstable releases available. I attempted to bisect the fix and arrived at lwindolf/liferea#1048. Not very backportable. @romildo WDYT of packaging unstable liferea to fix the build against current master? https://hydra.nixos.org/build/175432764

@romildo romildo mentioned this pull request May 4, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaxine amaxine Awaiting requested review from amaxine

@hedning hedning Awaiting requested review from hedning

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@dasj19 dasj19 Awaiting requested review from dasj19

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @trofi