Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/stale bot: stop commenting #171041

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Apr 30, 2022

Niklas Hambüchen (@nh2) noted in

NixOS/rfcs#124 (comment)

that we can add a label description for the stale label that appears
when you hover over the label, or look on

https://github.com/NixOS/nixpkgs/labels

I set the description to be

https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

which is our page explaining the stale bot.

The stale bot comments/emails are a significant burden on our most
prodigious contributors, and the reason for their existence to orient
new contributors.

Since our stale bot's configuration is benign enough to ignore (it
does not close), I believe it is good enough to satisfy the new
contributor orientation with the label description.

Therefore, this commit disables commenting when labeling an issue or
PR stale.

cc @blaggacao who worked on the comment with me last

Niklas Hambüchen noted in

NixOS/rfcs#124 (comment)

that we can add a label description for the stale label that appears
when you hover over the label, or look on

https://github.com/NixOS/nixpkgs/labels

I set the description to be

> https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

which is our page explaining the stale bot.

The stale bot comments/emails are a significant burden on our most
prodigious contributors, and the reason for their existence to orient
new contributors.

Since our stale bot's configuration is benign enough to ignore (it
does not close), I believe it is good enough to satisfy the new
contributor orientation with the label description.

Therefore, this commit disables commenting when labeling an issue or
PR stale.
@ryantm
Copy link
Member Author

ryantm commented Apr 30, 2022

One other thing to note is that some people like being reminded about their issues that hadn't been active in half a year. But I suspect this benefit only applies to a very small minority of the comments/emails.

Example: NixOS/rfcs#51 (comment)

@ryantm ryantm requested review from Profpatsch and nh2 April 30, 2022 15:55
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 30, 2022
@Ericson2314
Copy link
Member

One other thing to note is that some people like being reminded about their issues that hadn't been active in half a year. But I suspect this benefit only applies to a very small minority of the comments/emails.

There ought to be a way interested parties could query the issues with the API to get this information form the labels too, without having to spam everyone with comments.

@blaggacao
Copy link
Contributor

Side note: I'm still dreaming about workflow-engine type repo-automation beyond the capabilities of current readily available tooling.

I'm thinking in terms of how a modern and big insurance company would automate their business processes all across the board.

We are a modern and very big open source project.

End sidenote. 😊

@ryantm
Copy link
Member Author

ryantm commented May 9, 2022

I'm still hoping @Profpatsch can comment on this because I feel like he might want to represent the people who liked being notified.

@Artturin Artturin added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people labels May 9, 2022
@Artturin Artturin added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people labels May 18, 2022
@Artturin
Copy link
Member

(fixed the bug in label-approved) so the above won't happen again)

@SuperSandro2000
Copy link
Member

last call for @Profpatsch otherwise I would suggest to merge this in the next two or three days.

@SuperSandro2000 SuperSandro2000 merged commit 7d498de into NixOS:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants