scribus: Rename scribus{,Unstable} -> scribus{_1_4,} #172700
Conversation
|
@ofborg build scribus scribus_1_4 |
|
What I'm unsure about is whether there should be some kind of deprecation warning for the attribute |
|
@ofborg build scribus |
turion
force-pushed
the
dev_rename_scribus
branch
from
9c83f0c
to
5ea1fac
Compare
|
@ofborg build scribus |
pkgs/top-level/all-packages.nix
Outdated
| inherit (gnome2) libart_lgpl; | ||
| }; | ||
|
|
||
| scribusUnstable = libsForQt5.callPackage ../applications/office/scribus/unstable.nix { }; | ||
| scribus = libsForQt5.callPackage ../applications/office/scribus/default.nix { }; |
There was a problem hiding this comment.
Couldn't we then name this scribus_1_5 directly and make scribus an alias to that? This way we won't need to shuffle everything around when 1.6 gets released.
There was a problem hiding this comment.
I'm of a mind to actually delete the older scribus versions completely. But that doesn't have to happen right now.
Would you put the alias in pkgs/top-level/aliases.nix or right here?
There was a problem hiding this comment.
Considering that https://www.scribus.net/downloads/ still advertises 1.4 as the stable version I'd rather keep it as long as that doesn't change. I think we just can add scribus = scribus_1_5; here in that file.
Also it might make sense to mention the change in the release notes, so users that are depending on 1.4 get warned that they need to reference it explicitly. 1.4 and 1.5 have quite different user interfaces as far as I remember.
There was a problem hiding this comment.
https://www.scribus.net/downloads/ still advertises 1.4 as the stable version
Thanks, I didn't notice! Will do.
There was a problem hiding this comment.
scribus 1.4 depends on python2 and qt4, which have both been unsupported for years. I'm in favor of getting rid of it, even if the download page says that this is the stable version.
There was a problem hiding this comment.
@ajs124 Makes sense to me, but let's discuss that in another issue.
turion
force-pushed
the
dev_rename_scribus
branch
from
5ea1fac
to
fbbab02
Compare
turion
force-pushed
the
dev_rename_scribus
branch
from
fbbab02
to
1816b4e
Compare
turion
force-pushed
the
dev_rename_scribus
branch
from
1816b4e
to
28c8201
Compare
There was a problem hiding this comment.
This looks good to me!
Also checked that this is a noop for the two scribus attributes, so nothing should break from this.
I think I'll merge in ~3 days, but I want @MarcWeber as the other maintainer to have the chance to respond to the proposed change first.
|
Successfully created backport PR #174786 for |
Description of changes
Since 1.5 is the current published version, and 1.4 is already quite outdated and doesn't work without friction anymore, we should rename:
scribus -> scribus_1_4scribusUnstable -> scribusAnd we should keep major version updates to
scribus.CC @MarcWeber @erictapen @Kiwi
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes