Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncdns: unmark broken #184640

Merged
merged 1 commit into from
Aug 2, 2022
Merged

ncdns: unmark broken #184640

merged 1 commit into from
Aug 2, 2022

Conversation

SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 1, 2022
@onny
Copy link
Contributor

onny commented Aug 2, 2022

Couldn't this package also be updated to a more recent version? Looks like there is a 0.3.1 stable release available https://github.com/namecoin/ncdns/tags

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Aug 2, 2022

I've tried, but this package build is very unusual and I'm not too familiar with go modules.
Any assistance would be helpful.

@SuperSandro2000 SuperSandro2000 merged commit 9256496 into NixOS:master Aug 2, 2022
@SuperSandro2000 SuperSandro2000 deleted the ncdns branch August 2, 2022 09:40
@SuperSandro2000
Copy link
Member Author

Couldn't this package also be updated to a more recent version?

I am just cleaning up after the go 1.18 bump. I vaguely remember that updating the package wasn't that easy because it is a little mess. The package maintainer or someone who actually uses the package should rather update it.

@SuperSandro2000
Copy link
Member Author

Now I remember why we marked this broken: nix build .#ncdns.go-modules --rebuild fails which means the vendor tarball is outdated right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants