Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml: 4.02 -> 4.03.0 #18776

Closed
wants to merge 1 commit into from
Closed

Conversation

sjmackenzie
Copy link
Contributor

Motivation for this change

Tezos requires ocaml-4-03 to run: https://github.com/tezos/tezos/blob/master/scripts/install_build_deps.sh#L3

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@the-kenny
Copy link
Contributor

is there a good reason to keep four 4.x releases of ocaml?

@sjmackenzie
Copy link
Contributor Author

This question is a separate issue.

@sjmackenzie
Copy link
Contributor Author

sjmackenzie commented Sep 20, 2016

probably better to solve the your problem by opening an issue similar to this: #18111

@the-kenny
Copy link
Contributor

The issue you linked is irrelevant here. This isn't about Hydra at all.

I don't think it's a separate issue, as we would have to invest more time in cleaning up if we decide that it's unnecessary to keep multiple past minor releases of ocaml.

Other than this, your 4.03.nix looks like a copy of 4.02.nix. I suggest refactoring so both use the same base as the same base and just override version and src for the respective release.

@sjmackenzie
Copy link
Contributor Author

sjmackenzie commented Sep 20, 2016

Your problem of too many ocaml versions is subjective, refer to ghc and llvm please. Secondly, regarding the #18111 issue, the poll I suggested you make would effectively communicate your problem to the ocaml community so they can make such a decision! Till then if you find this PR unacceptable I'll just close it immediately. Wouldn't want to add noise to signal ;-)

@sjmackenzie
Copy link
Contributor Author

sjmackenzie commented Sep 20, 2016

My suggestion: @the-kenny please merge this separate issue #18765 so I can refactor my PR.

@thufschmitt
Copy link
Member

thufschmitt commented Sep 22, 2016

There already is a waiting pr for this (#17147), which avoids copy-pasting and adds the ocamlbuild package (which was part of the ocaml distribution until 4.02, and needed by most ocaml packages).

EDIT: typo

@sjmackenzie
Copy link
Contributor Author

That #17147 issue has been sitting around since July 2016, If a commiter could be so kind and efficiently swoop in and merge #17147 then please close this issue. cc @7c6f434c @peti @edolstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants