vimPlugins: make usage of luaPackages less confusing #190824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
labels
teto
force-pushed
the
vimPlugins-lua-update
branch
from
dc02cef
to
b191a37
Compare
teto
commented
Sep 12, 2022
| @@ -26,7 +26,7 @@ in | |||
| lua_modules_path = "lua" | |||
| ''; | |||
| }); | |||
| finalDrv = toVimPlugin (luaDrv.overrideAttrs(oa: { | |||
| finalDrv = toVimPlugin (luaDrv.overrideAttrs(oa: (builtins.removeAttrs attrs ["version"]) // { | |||
There was a problem hiding this comment.
removing the version number is also confusing because the derivation name will use a version different than the src's but keeping it breaks luarocks builder. I need to address that.
systemd: 251.4 -> 251.5
We run pytest with `--forked` in nixpkgs, to reduce side effects that can occur when multiple tests mutate their environment in incompatible ways. Forking on macOS 10.13 and later is unsafe when an application does work between calls to fork() and its followup exec(). This may lead to crashes when calls into the Objective-C runtime are issued, which will in turn coredump the Python interpreter. One good reproducer for this scenario is when the urllib module tries to lookup proxy configurations in `urllib.request.getproxies()` through `get_proxies_macos_sysconf` into the native `_scproxy` module. This is a class of issues that is of course not limited to the urllib module. The general recommendation is to use `spawn` instead of `fork`, but we don't have any influence on upstream developers to do one or the other. One often cited workaround would be to disable fork safety entirely on calls to `initialize()`, which is probably a better solution than running without multithreading (slow) or without the `--forked` (prone to side effects) mode. This currently happens on aarch64-linux only, where we use more recent 11.0 SDK version, while x86_64-darwin has been stuck on 10.12 for a while now. python/cpython#77906 (comment) http://www.sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html Closes: NixOS#194290
apparmor: 3.0.7 -> 3.1.1
or it will end up in the dist output.
Typically the actual wheel will be unchanged, but it is possible we use the relax deps hook modifying the wheel.
systemd: don't taint on unmerged /usr
…irection Validated as no change in `out`, `man`, `doc` outputs with diffoscope on `ghostscript` expression.
Support systemd-portabled
flac: build with cmake, fixes cross compilation
31 tasks
…er indirection Validated as no change in `out` and `dev` outputs with diffoscope on `gnome2.libgnomeui` expression.
teto
force-pushed
the
vimPlugins-lua-update
branch
3 times, most recently
from
acc4262
to
ae94b3f
Compare
right now the src is ignored in:
```
lush-nvim = buildNeovimPlugin {
pname = "lush.nvim";
version = "2022-08-09";
src = fetchFromGitHub {
owner = "rktjmp";
repo = "lush.nvim";
rev = "6b9f399245de7bea8dac2c3bf91096ffdedfcbb7";
sha256 = "0rb77rwmbm438bmbjfk5hwrrcn5sihsa1413bdpc27rw3rrn8v8z";
};
meta.homepage = "https://github.com/rktjmp/lush.nvim/";
};
```
which is very confusing. With this PR, we correctly override the src and
the version of the package. We introduce a rockspecVersion attribute of
lua package to be able to still find the rockspec when the
"version" field needs to be different than "rockspecVersion".
teto
force-pushed
the
vimPlugins-lua-update
branch
from
ae94b3f
to
91a3f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #185397
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes