Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mullvad-vpn: change dependency for the daemon to pkg mullvad #191082

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

arcuru
Copy link
Contributor

@arcuru arcuru commented Sep 13, 2022

Description of changes

This changes the provider of the mullvad-daemon for the service module from mullvad-vpn to mullvad. The mullvad-vpn package includes the GUI, which is only available on x86-64, while the mullvad package does not and is available cross-platform.

Related: #157207 by @cole-h

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@cole-h cole-h merged commit 4c69843 into NixOS:master Oct 11, 2022
@cole-h
Copy link
Member

cole-h commented Oct 11, 2022

Oh, probably should document this in the release notes. Would you like to do that (edit: in a new PR, of course...), or should I, @patricksjackson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants