Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19382 set ownership of /var/empty to root:root #19383

Merged
merged 1 commit into from
Oct 9, 2016

Conversation

nathan-gs
Copy link
Member

@nathan-gs nathan-gs commented Oct 9, 2016

Motivation for this change

See #19382.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@nathan-gs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nathan7 and @domenkozar to be potential reviewers.

@nathan-gs
Copy link
Member Author

@domenkozar looks like you are most suited to review this.

@domenkozar
Copy link
Member

Oh I forgot the most crucial leftover of #14910 :( Thanks!

@domenkozar domenkozar merged commit 4725a09 into NixOS:master Oct 9, 2016
@cottand cottand mentioned this pull request Dec 14, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants