nixos/modules/installer/sd-card/sd-image-mips64el.nix: init #194153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: kernel
ofborg
bot
added
10.rebuild-darwin: 0
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
ghost
requested review from
alyssais,
Ericson2314 and
matthewbauer
as code owners
|
Okay, this builds again. I will try booting it tonight. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ghost
marked this pull request as draft
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 501+
10.rebuild-linux: 2501-5000
and removed
10.rebuild-darwin: 0
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg build pkgsCross.octeon.linux |
|
ghost
mentioned this pull request
12 tasks
ofborg
bot
added
the
2.status: merge conflict
|
Switched branches to |
|
@ofborg build pkgsCross.octeon.linux_latest |
ofborg
bot
removed
the
2.status: merge conflict
samueldr
reviewed
Jul 29, 2023
Comment on lines
24
to
26
|
|
||
| nixpkgs.buildPlatform = builtins.currentSystem; | ||
| nixpkgs.hostPlatform = lib.systems.examples.octeon; |
There was a problem hiding this comment.
I'm not sure I can review anything else, but there's at least this.
This would need to use mips64el (since it's the name of the file) or rename the file for octeon. I'd prefer targeting the generic mips64el and users needing octeon can provide a host platform.
But actually, with a bit more thought, SD/ISO builds should be made assuming native builds. Cross-compiling usage is done externally through configuring platforms. Look at all the other existing sd image configs. So actually removing the lines is the correct resolution here.
Suggested change
| nixpkgs.buildPlatform = builtins.currentSystem; | |
| nixpkgs.hostPlatform = lib.systems.examples.octeon; |
There was a problem hiding this comment.
@roberth is insisting that it be done this way -- through module parameters.
Perhaps one of you can convince the other.
There was a problem hiding this comment.
(I left a comment on the other PR)
There is no convincing to do, and we agree, and this comment here agrees with the idea that cross-compilation is configured through the NixOS configuration.
There was a problem hiding this comment.
This module is a "profile" module that's specifically about mips64el, so it does make sense to set a default hostPlatform, but buildPlatform is not specific to mips64el hosts and therefore shouldn't be set here.
ghost
mentioned this pull request
12 tasks
added 3 commits
August 1, 2023 15:27
…latform p11-kit does not cross-compile. This prevents the NixOS installer from cross-compiling. Therefore, we mark it broken in this case and omit it.
The libnvme documentation fails to build when cross compiling, with:
FAILED: doc/nvme_admin_opcode.2
/nix/store/qcvcsink30f4wh36jzg3rbvkshwzj38c-meson-1.1.1/bin/meson --internal exe --capture doc/nvme_admin_opcode.2 -- /build/source/doc/kernel-doc -module libnvme -man -function nvme_admin_opcode ../doc/../src/nvme/types.h
Traceback (most recent call last):
File "/nix/store/qcvcsink30f4wh36jzg3rbvkshwzj38c-meson-1.1.1/bin/meson", line 6, in <module>
File "/nix/store/qcvcsink30f4wh36jzg3rbvkshwzj38c-meson-1.1.1/lib/python3.10/site-packages/mesonbuild/mesonmain.py", line 30, in <module>
from . import mlog
ImportError: cannot import name 'mlog' from 'mesonbuild' (/nix/store/qcvcsink30f4wh36jzg3rbvkshwzj38c-meson-1.1.1/lib/python3.10/site-packages/mesonbuild/__init__.py)
[703/811] Generating doc/nvme_identify_cns_man with a custom command (wrapped by meson to capture output)
FAILED: doc/nvme_identify_cns.2
/nix/store/qcvcsink30f4wh36jzg3rbvkshwzj38c-meson-1.1.1/bin/meson --internal exe --capture doc/nvme_identify_cns.2 -- /build/source/doc/kernel-doc -module libnvme -man -function nvme_identify_cns ../doc/../src/nvme/types.h
Traceback (most recent call last):
File "/nix/store/qcvcsink30f4wh36jzg3rbvkshwzj38c-meson-1.1.1/bin/meson", line 6, in <module>
File "/nix/store/qcvcsink30f4wh36jzg3rbvkshwzj38c-meson-1.1.1/lib/python3.10/site-packages/mesonbuild/mesonmain.py", line 30, in <module>
from . import mlog
|
Rebased. |
This cross-compiles a complete NixOS installer image. The image is built specifically for Cavium Octeon chips, because currently these are the Mips64 products that are commercially available: you can order a Ubiquiti Edgerouter from Amazon and have it the next day. All of Debian's non-Longsoon MIPS builders are Octeons: https://wiki.debian.org/MIPSPort Co-authored-by: Samuel Dionne-Riel <[email protected]>
ghost
mentioned this pull request
12 tasks
|
The full installer builds from |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/binary-cache-for-riscv64/44934/3 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This cross-compiles a complete NixOS installer image.
Includes:
For cross compilation, you will need: