-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsmartcard-vpcd, vsmartcard-pcsc-relay: init at 0.9-unstable-2024-05-14, nixos/vsmartcard-vpcd: init #194957
base: master
Are you sure you want to change the base?
Conversation
cf68511
to
90973c9
Compare
26e726f
to
bbae746
Compare
bbae746
to
70840a2
Compare
70840a2
to
244f35d
Compare
8990737
to
35f59a0
Compare
35f59a0
to
667783d
Compare
667783d
to
b134cce
Compare
as for the configuration of pcscd, would it be preferable to provide configuration options instead of the
The service definition would then generate and append the configuration to |
a9b6474
to
c0c180f
Compare
28cac7e
to
046f302
Compare
@SuperSandro2000 I have implemented all of your suggestions, thank you! I have also added a service module definition to make configuring the PCSC driver (with the default options) just a simple matter of
The options The |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4220 |
50cb362
to
f5dd523
Compare
Thank you @SuperSandro2000 for you suggestions, I have implemented them. |
88b1dd1
to
1c322c3
Compare
1c322c3
to
16af0c5
Compare
Description of changes
This PR adds the virtual smart card reader and relay: https://frankmorgner.github.io/vsmartcard/ . It can be used to e.g. emulate a smartcard when combined with e.g. https://jcardsim.org/ , or to debug smartcard communications via an Android phone bridge.
The service module
service.services.vsmartcard-vpcd
is used to enable and configure the virtual smart card driver. It appends a configuration to thepcscd
readers.conf
. To facilitate this, thereaderConfig
option ofservices.pcscd
was upgraded to a listreaderConfigs
, which is internally joined into the single config file. The oldreaderConfig
option has been marked as deprecated, but continues to work.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes