Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-multiple-choice: fix build on darwin #199197

Merged
merged 1 commit into from
Nov 7, 2022
Merged

auto-multiple-choice: fix build on darwin #199197

merged 1 commit into from
Nov 7, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 2, 2022 •
edited
Loading

Description of changes

ZHF #199919.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 2, 2022
@ofborg ofborg bot requested a review from thblt November 2, 2022 17:42
@thblt
Copy link
Contributor

thblt commented Nov 2, 2022

Have you tested the output?

@wegank wegank force-pushed the auto-multiple-choice-darwin branch from 7fd0967 to bff8d69 Compare November 2, 2022 18:49
@wegank
Copy link
Member Author

wegank commented Nov 2, 2022

@thblt

Capture d’écran 2022-11-02 à 19 50 42

thblt
thblt approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@thblt thblt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building on GNU/Linux is unaffected
lgtm

@wegank wegank force-pushed the auto-multiple-choice-darwin branch from bff8d69 to f16bbb5 Compare November 6, 2022 13:01
@ofborg ofborg bot requested a review from thblt November 6, 2022 13:12
@mweinelt mweinelt merged commit 9dca9ad into NixOS:master Nov 7, 2022
@wegank wegank deleted the auto-multiple-choice-darwin branch November 7, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thblt thblt Awaiting requested review from thblt

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wegank @thblt @mweinelt