Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

honeycomb-refinery: init at 1.19.0 #200424

Merged
merged 1 commit into from
Nov 22, 2022
Merged

honeycomb-refinery: init at 1.19.0 #200424

merged 1 commit into from
Nov 22, 2022

Conversation

lf-
Copy link
Member

@lf- lf- commented Nov 9, 2022

Description of changes

This is a tail sampling proxy for OpenTelemetry, which collects full traces in-memory, then makes sampling decisions, finally sending traces out if they were chosen to be sampled.

https://github.com/honeycombio/refinery

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@lf-
Copy link
Member Author

lf- commented Nov 9, 2022

hm. no idea if this is on time for the release freeze. Possibly not. If not, oh well. It can get merged later.

9999years
9999years approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@9999years 9999years left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lf-
Copy link
Member Author

lf- commented Nov 13, 2022

Applied all the suggestions & updated to 1.19.0 since it just came out

@lf- lf- changed the title honeycomb-refinery: init at 1.18.0 honeycomb-refinery: init at 1.19.0 Nov 13, 2022
@lf- lf- requested a review from azahi November 16, 2022 20:00
@azahi azahi added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 16, 2022
@Gabriella439 Gabriella439 merged commit 694cd66 into NixOS:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azahi azahi azahi approved these changes

@9999years 9999years 9999years approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lf- @9999years @azahi @Gabriella439