Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustracer: remove (deprecated) #203243

Merged
merged 1 commit into from
Nov 28, 2022
Merged

rustracer: remove (deprecated) #203243

merged 1 commit into from
Nov 28, 2022

Conversation

seanrmurphy
Copy link
Contributor

@seanrmurphy seanrmurphy commented Nov 27, 2022

This PR originally contained a solution for building rustracer. However, the solution involved using overlays which are not permitted by hydra. @Mic92 suggested that it made more sense to remove this package - given that it is essentially deprecated in favour of packages such as rust-analyzer - rather than putting energy into trying to fix it.

Description of changes
  • Fixed the build for ZHF (🦝 NixOS 22.11 - Zero Hydra Failures #199919) at #ZurichZHF :)
  • Pinned rust channel to old nightly as per issue in repo, added extensions required for build
  • Bumped version to 2.2.2 as per Cargo.toml; note that there has not been a 2.2.2 tagged release in the repo and hence a specific commit is fetched from github

This package has basically been deprecated in favour of rust-analyzer and hence it will likely make sense to pull it out of nixpkgs at some point.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@seanrmurphy seanrmurphy changed the title rustracer: fix build rustracer: remove (deprecated) Nov 27, 2022
@Mic92
Copy link
Member

Mic92 commented Nov 27, 2022

Can you also add the removed attribute to pkgs/top-level/aliases.nix so that other people see why this was removed?

@SuperSandro2000
Copy link
Member

and squash the commits afterwards

@seanrmurphy
Copy link
Contributor Author

@Mic92 Is this adequate/appropriate for indicating removal? I'm not sure if it's at the right place in the file; rustracerd was there already - seemed sensible to put it next to that.

rustracer = throw "rustracer has been removed as it has been deprecated"; # Added 2022-11-28

@github-actions
Copy link
Contributor

Successfully created backport PR #203431 for release-22.11.

@seanrmurphy seanrmurphy deleted the fix/rustracer branch November 28, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants