Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.libpciaccess: fix build on NetBSD #210485

Merged
merged 4 commits into from
Jan 13, 2023
Merged

xorg.libpciaccess: fix build on NetBSD #210485

merged 4 commits into from
Jan 13, 2023

Conversation

alyssais
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais alyssais added the 6.topic: bsd Running or building packages on BSD label Jan 13, 2023
@alyssais alyssais changed the title libpciaccess: fix build on NetBSD xorg.libpciaccess: fix build on NetBSD Jan 13, 2023
@alyssais alyssais marked this pull request as draft January 13, 2023 04:47
@alyssais alyssais changed the base branch from master to staging January 13, 2023 04:47
@alyssais alyssais closed this Jan 13, 2023
@alyssais alyssais reopened this Jan 13, 2023
@alyssais alyssais marked this pull request as ready for review January 13, 2023 04:49
Ericson2314
Ericson2314 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Ericson2314 Ericson2314 merged commit b7ceddd into NixOS:staging Jan 13, 2023
@alyssais alyssais deleted the libpciaccess-netbsd branch January 13, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
6.topic: bsd Running or building packages on BSD 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssais @Ericson2314