Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bintools: Add response file support to ld-wrapper #213831

Merged

Commits on Feb 3, 2023

  1. bintools: Add response file support to ld-wrapper

    The motivation behind this is to alleviate the problem
    described in NixOS#41340.
    I'm not sure if this completely fixes the problem, but it
    eliminates one more area where we can exceed command line
    length limits.
    
    This is essentially the same change as in NixOS#112449,
    except for `ld-wrapper.sh` instead of `cc-wrapper.sh`.
    
    However, that change alone was not enough; on macOS the
    `ld` provided by `darwin.cctools` fails if you use process
    substitution to generate the response file, so I put up a
    PR to fix that:
    
    tpoechtrager/cctools-port#131
    
    … and I included a patch referencing that fix so that the
    new `ld-wrapper` still works on macOS.
    Gabriella439 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4ffd094 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Include additional fix to ld

    Without this fix `ld` fails when response files are enabled and
    the command line length exceeds 64KB.  For more details, see:
    
    tpoechtrager/cctools-port#132
    Gabriella439 committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1d9ab50 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Update patch URL

    The hash remains the same (I checked)
    Gabriella439 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    97bde4f View commit details
    Browse the repository at this point in the history