-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: apply patch to fix delay_span_bug ICE #214792
Conversation
@NixOS/rust The upstream patch hasn't been approved. Assuming we have to land this today to get it in for this cycle (along with the scheduled OpenSSL update), we have two options:
Thoughts? |
How urgent is the OpenSSL update? Looking at hydra, the regression doesn't seem to effect much more packages, perhaps we can just add back rust 1.66 for vector if we can't apply the patch in time? |
High severity per the announcement.
I'd be open to that since it won't even have to hit staging. |
Rust 1.67.0 introduced a regression that caused an ICE when building Vector. https://hydra.nixos.org/build/207931877 rust-lang/rust#107691 rust-lang/rust#107688
b4955f2
to
5c9bcdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm, just waiting for upstream to be approved
@figsoda Upstream approved them, which is why I undrafted this. |
Ah I misunderstood rust-lang/rust#107688 (comment), this is good to go once CI's done |
@ofborg build vector |
Vector built on both Linux architectures, and Darwin is timing out as expected. Let's do it. |
was just about to do that lol |
Description of changes
https://hydra.nixos.org/build/207931877
rust-lang/rust#107691
rust-lang/rust#107688
Things done
nix-build -A vector
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes