Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnupg: look for system wide config files at /etc/gnupg/* rather than … #218703

Merged
merged 1 commit into from
Apr 12, 2023
Merged

gnupg: look for system wide config files at /etc/gnupg/* rather than … #218703

merged 1 commit into from
Apr 12, 2023

Conversation

SuperSandro2000
Copy link
Member

…in the nix store

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and vrthra February 27, 2023 23:30
@SuperSandro2000 SuperSandro2000 requested review from rnhmjoj and removed request for vrthra and fpletz February 27, 2023 23:34
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging February 27, 2023 23:35
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 28, 2023

What kind of configuration is this path supposed to contain? The package doesn't ship with any.

@SuperSandro2000
Copy link
Member Author

Global gpg configs, similar to ~/.gnupg. Before this, gnupg would look into the nix store where the config will be never.

@ofborg ofborg bot requested review from vrthra and fpletz April 11, 2023 11:55
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 11, 2023

Would this help with #213794?

@SuperSandro2000
Copy link
Member Author

We could write the config into the global directory which I hope helps but I didn't try it in practice.

@Artturin Artturin merged commit 956d034 into NixOS:staging Apr 12, 2023
@SuperSandro2000 SuperSandro2000 deleted the gnupg-sysconfdir branch April 18, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@vrthra vrthra Awaiting requested review from vrthra

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperSandro2000 @rnhmjoj @Artturin