Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nim: 1.6.10 -> 1.6.12 #220540

Merged
merged 1 commit into from
Mar 19, 2023
Merged

nim: 1.6.10 -> 1.6.12 #220540

merged 1 commit into from
Mar 19, 2023

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Mar 10, 2023

Description of changes

https://nim-lang.org/blog/2023/03/10/version-1612-released.html
nim-lang/Nim@v1.6.10...v1.6.12

Things done

Nitter builds.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ehmry ehmry added the 6.topic: nim Nim programing language label Mar 10, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Mar 10, 2023
@ehmry ehmry marked this pull request as ready for review March 11, 2023 00:17
@trofi
Copy link
Contributor

trofi commented Mar 19, 2023

Result of nixpkgs-review pr 220540 run on x86_64-linux 1

1 package marked as broken and skipped:
  • hottext
44 packages built:
  • mosdepth
  • nim (nimPackages.nim)
  • nim-unwrapped
  • nimPackages.asciigraph
  • nimPackages.asynctools
  • nimPackages.base32
  • nimPackages.base45
  • nimPackages.bumpy
  • nimPackages.c2nim
  • nimPackages.cbor
  • nimPackages.flatty
  • nimPackages.getdns
  • nimPackages.hts-nim
  • nimPackages.illwill
  • nimPackages.jsonschema
  • nimPackages.jsony
  • nimPackages.nimSHA2
  • nimPackages.nim_builder
  • nimPackages.npeg
  • nimPackages.parsetoml
  • nimPackages.pixie
  • nimPackages.rocksdb
  • nimPackages.sass
  • nimPackages.sdl2
  • nimPackages.snappy
  • nimPackages.spry
  • nimPackages.spryvm
  • nimPackages.stew
  • nimPackages.taps
  • nimPackages.tempfile
  • nimPackages.tkrzw
  • nimPackages.ui
  • nimPackages.vmath
  • nimPackages.zippy
  • nimble-unwrapped
  • nimlsp
  • nimmm
  • nitch
  • nitter
  • nrpl
  • swaycwd
  • tridactyl-native
  • ttop
  • vimPlugins.fruzzy

@ehmry ehmry merged commit 3125412 into NixOS:master Mar 19, 2023
@vcunat
Copy link
Member

vcunat commented Mar 20, 2023

FYI this regressed on *-darwin as you could also see from ofBorg CI here. On Hydra: https://hydra.nixos.org/eval/1792278?filter=nim.

@trofi
Copy link
Contributor

trofi commented Mar 20, 2023

Might be a fetch failure? https://hydra.nixos.org/build/213226629 looks like a timing out tarball derivation.

@vcunat
Copy link
Member

vcunat commented Mar 20, 2023

Uuh, temporary machine failure apparently. I restarted that build to get the real failure.

@jakubgs jakubgs mentioned this pull request Mar 20, 2023
13 tasks
@trofi
Copy link
Contributor

trofi commented Mar 20, 2023

Aha, looks like a missing darwin.Security depend:

ld: framework not found Security
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

@trofi
Copy link
Contributor

trofi commented Mar 20, 2023

Proposed possible fix as #222243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nim Nim programing language 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants