-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prisma-engines: 4.11.0 -> 4.12.0 #223700
prisma-engines: 4.11.0 -> 4.12.0 #223700
Conversation
It doesn't relate directly to this PR, but I don't understand why we have a committed Cargo.lock in nixpkgs now, it wasn't the case until very recently and I didn't get a notification when that happened. Git blame points to 0f2c778 but that's not super helpful. Does anybody have more context? Otherwise the PR looks good to me. You might want to update nodePackages.prisma too. |
Ok found when and how that happened: #221716 |
Result of 1 package built:
|
Hey, @ivan! Thanks for this, we need more maintainers. One thing missing is that by just updating Just update the new sum, rebuild and create two commits: one updating |
@pimeys thanks for the review. I updated the hash for nodePackages.prisma now. |
Result of 1 package built:
|
Description of changes
prisma/prisma-engines@4.11.0...4.12.0
https://github.com/prisma/prisma/releases/tag/4.12.0
I removed
"-p" "introspection-core"
because introspection-core is gone in prisma-engines.I copied
Cargo.lock
from [email protected].Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)cc maintainers @Pamplemousse @pimeys @tomhoule