Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headscale: change 'sha256'-style attributes 'hash'-style attributes #227783

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

johnrichardrinehart
Copy link
Contributor

Description of changes

Reverts the change set in #227351 which altered the attributes from the hash style to the sha256 style.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@06kellyjac

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 23, 2023
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we haven't decided whether SRI hash and the hash attribute is the preferred way forward (NixOS/rfcs#131), but hash looks nicer/DRYer than sha256 anyway. ¯_(ツ)_/¯

@NickCao NickCao merged commit 5649872 into NixOS:master Apr 23, 2023
@johnrichardrinehart
Copy link
Contributor Author

Actually we haven't decided whether SRI hash and the hash attribute is the preferred way forward (NixOS/rfcs#131), but hash looks nicer/DRYer than sha256 anyway. ¯_(ツ)_/¯

Okay, I was told to keep them unchanged (hash and vendorHash) in #227351 (comment) . So, people seem to have different opinions about what should be.

@06kellyjac
Copy link
Member

The TLDR is whichever the maintainers prefer, no reason to change it otherwise. Thanks for changing it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants