Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple_sdk: remove cf-private alias #229314

Merged
merged 1 commit into from
May 2, 2023

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented May 1, 2023

Description of changes

Removed use of the cf-private alias to darwin.apple_sdk.frameworks.CoreFoundation from Nixpkgs. Actual removal of the cf-private attribute will be done later, after the 23.05 release: #229389.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@@ -1,6 +1,5 @@
{ lib, stdenv
, fetchFromGitHub
, unstableGitUpdater
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused in the derivation so I removed it as general cleanup.

@ConnorBaker ConnorBaker marked this pull request as ready for review May 1, 2023 16:19
@ConnorBaker ConnorBaker requested review from wegank and fgaz May 1, 2023 16:19
@ConnorBaker ConnorBaker self-assigned this May 1, 2023
@ConnorBaker ConnorBaker added the 6.topic: darwin Running or building packages on Darwin label May 1, 2023
@figsoda
Copy link
Member

figsoda commented May 1, 2023

Should this maybe throw a warning first before turning into a hard error?

Also breaking changes are now restricted, see #223562

@wegank
Copy link
Member

wegank commented May 1, 2023

Let's only keep cf-private = self.apple_sdk.frameworks.CoreFoundation; then.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 1, 2023
@ConnorBaker ConnorBaker force-pushed the fix/apple-sdk-remove-cf-private branch from 8770902 to b2eb5c8 Compare May 2, 2023 01:59
@ConnorBaker
Copy link
Contributor Author

Created #229389 to track removal after 23.05 is cut.

@figsoda what's best practice for doing deprecations of the sort to alert out-of-tree users that the attribute is going away? Additionally, is there a schedule I should follow for that?

@ConnorBaker ConnorBaker requested a review from figsoda May 2, 2023 02:02
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels May 2, 2023
@wegank wegank merged commit 9433be1 into NixOS:master May 2, 2023
@ConnorBaker ConnorBaker deleted the fix/apple-sdk-remove-cf-private branch May 28, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants