Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nest-cli: repackage using buildNpmPackage #229692

Merged
merged 1 commit into from
May 6, 2023

Conversation

ehllie
Copy link
Contributor

@ehllie ehllie commented May 3, 2023

Description of changes

Repackages nodePackages.@nestjs/cli to be built using buildNpmPackage as per the suggestion in #229475

Things done

Moved nest-cli to pkgs/development/tools and removed it from node-packages.json.
Had to regenerate package-lock.json after running npm upgrade to fix the build failing on Darwin.
Once #229639 gets merged I will also include it in aliases.nix that it adds.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and add an alias

@ehllie
Copy link
Contributor Author

ehllie commented May 5, 2023

Please rebase and add an alias

I have done that, but I have an issue I pointed out here #229639 (comment). As it stands nodePackages.@nestjs/cli does not evaluate because it shadows the package in node-packages.nix, which I would like to avoid having to manually edit or re generate.

@ehllie
Copy link
Contributor Author

ehllie commented May 6, 2023

I've also deleted @nestjs/cli from node-packages.nix so that the alias is not an error in case we want to stay with the current iteration of the alias file

@SuperSandro2000 SuperSandro2000 merged commit 75b4d0f into NixOS:master May 6, 2023
@ehllie ehllie deleted the nest-cli branch May 6, 2023 14:51
@dotlambda
Copy link
Member

Had to regenerate package-lock.json after running npm upgrade to fix the build failing on Darwin.

Did you ask upstream to regenerate their lock file? We cannot add 15k lines of code for every single package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants