-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nest-cli: repackage using buildNpmPackage #229692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and add an alias
I have done that, but I have an issue I pointed out here #229639 (comment). As it stands |
I've also deleted |
Did you ask upstream to regenerate their lock file? We cannot add 15k lines of code for every single package. |
Description of changes
Repackages
nodePackages.@nestjs/cli
to be built using buildNpmPackage as per the suggestion in #229475Things done
Moved
nest-cli
topkgs/development/tools
and removed it fromnode-packages.json
.Had to regenerate
package-lock.json
after runningnpm upgrade
to fix the build failing on Darwin.Once #229639 gets merged I will also include it in
aliases.nix
that it adds.sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)