nodePackages.{triton,manta}: repackage using buildNpmPackage #230158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutat3s
changed the title
|
Related #229475 |
teutat3s
changed the title
winterqt
changed the title
winterqt
requested changes
May 5, 2023
ofborg
bot
added
8.has: package (new)
SuperSandro2000
requested changes
May 5, 2023
teutat3s
force-pushed
the
triton-buildnpmpackage
branch
from
384e09b
to
ec3a09b
Compare
SuperSandro2000
approved these changes
May 6, 2023
Renamed package to node-manta, because manta is already taken
SuperSandro2000
force-pushed
the
triton-buildnpmpackage
branch
from
ec3a09b
to
9115820
Compare
|
@ofborg build triton node-manta |
teutat3s
commented
May 8, 2023
| @@ -37,4 +37,5 @@ mapAliases { | |||
| "@antora/cli" = pkgs.antora; | |||
| "@githubnext/github-copilot-cli" = pkgs.github-copilot-cli; # Added 2023-05-02 | |||
| "@nestjs/cli" = pkgs.nest-cli; | |||
| trito = pkgs.triton; # Added 2023-05-06 | |||
There was a problem hiding this comment.
I missed this typo: trito -> triton
12 tasks
|
@teutat3s Can you make an upstream PR committing |
This was referenced Sep 13, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
nodePackages.tritonto buildNpmPackagenodePackages.mantato buildNpmPackagetritonandmantanodePackages.mantatonode-manta, becausemantais already takenIf desired, can be split up into two separate PRs.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)