-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/chromium: add enablePlasmaBrowserIntegration option #232528
Conversation
@K900 can you have look? |
The Plasma bits look OK, not sure about the Chromium bits. Also, it might be time to add some sort of centralized option for native messaging hosts... |
Yeah, the current way does not scale but I am not planning do that right now due to the lack of time. |
Hey could you also add support for Vivaldi? It too is based on Chromium and has a specific path for the native host messaging host like how Brave does |
I don't use vivaldi and don't have the time to verify them. Please create a separate PR. @K900 so what do we do about this? |
3ea51fd
to
4ed55fd
Compare
d06fa36
to
75fc0c8
Compare
Updated to work with Plasma 6 from #286522 |
It would probably be better if the formatting was done in a spearate PR, makes it hard to see what was changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to review commit-by-commit, but the diff LGTM
I can move it to an extra commit but doing in a separate PR is way to much hassle. |
this also reduces the diff in the next commits
75fc0c8
to
d449e88
Compare
@ofborg test chromium |
aarch64-linux failed (timeout?) building chromium, LGTM |
Description of changes
Closes #85342
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)