Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/chromium: add enablePlasmaBrowserIntegration option #232528

Merged
merged 5 commits into from
Feb 10, 2024

Conversation

SuperSandro2000
Copy link
Member

Description of changes

Closes #85342

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` labels May 18, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 18, 2023
@SuperSandro2000 SuperSandro2000 changed the title Chromium kde nixos/chromium: add enablePlasmaBrowserIntegration option May 22, 2023
@SuperSandro2000
Copy link
Member Author

@K900 can you have look?

@K900
Copy link
Contributor

K900 commented Sep 4, 2023

The Plasma bits look OK, not sure about the Chromium bits. Also, it might be time to add some sort of centralized option for native messaging hosts...

@SuperSandro2000
Copy link
Member Author

Yeah, the current way does not scale but I am not planning do that right now due to the lack of time.

@NovaViper
Copy link
Contributor

Hey could you also add support for Vivaldi? It too is based on Chromium and has a specific path for the native host messaging host like how Brave does

@SuperSandro2000
Copy link
Member Author

I don't use vivaldi and don't have the time to verify them. Please create a separate PR.


@K900 so what do we do about this?

@SuperSandro2000
Copy link
Member Author

Updated to work with Plasma 6 from #286522

@yisraeldov
Copy link
Contributor

It would probably be better if the formatting was done in a spearate PR, makes it hard to see what was changed.

Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to review commit-by-commit, but the diff LGTM

@SuperSandro2000
Copy link
Member Author

It would probably be better if the formatting was done in a spearate PR, makes it hard to see what was changed.

I can move it to an extra commit but doing in a separate PR is way to much hassle.

@pbsds
Copy link
Member

pbsds commented Feb 9, 2024

@ofborg test chromium

@pbsds
Copy link
Member

pbsds commented Feb 10, 2024

aarch64-linux failed (timeout?) building chromium, LGTM

@pbsds pbsds merged commit 40cb108 into NixOS:master Feb 10, 2024
23 of 24 checks passed
@SuperSandro2000 SuperSandro2000 deleted the chromium-kde branch February 11, 2024 22:13
K900 added a commit to K900/nixpkgs that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium extension that uses native messaging does not work
5 participants