Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.easyeffects-preset-selector: patch EasyEffects schema source #233642

Merged
merged 1 commit into from
May 23, 2023

Conversation

4JX
Copy link
Contributor

@4JX 4JX commented May 23, 2023

Description of changes

Patches the extension such that it can find the settings of easyeffects.

Was not sure on if the inputs were following a specific order so I just added them at the end.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 23, 2023
@piegamesde
Copy link
Member

Except for lib and maybe a couple of mistakes, the inputs are sorted alphabetically. Same for the patches.

@4JX
Copy link
Contributor Author

4JX commented May 23, 2023

Except for lib and maybe a couple of mistakes, the inputs are sorted alphabetically. Same for the patches.

Ah I see, libgtop's position threw my brain way off. Took the liberty of repositioning it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants